git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/grep.c: remote superflous submodule code

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 7, 2018, 00:29 UTC
Message-ID
<xmqqlg7avbtt.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181005224557.31420-1-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 11 quoted lines
> In f9ee2fcdfa (grep: recurse in-process using 'struct repository',
> 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep
> to simplify the submodule handling.
>
> After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules
> file, 2017-08-03) this is no longer necessary, but that commit did not
> cleanup the whole tree, but just show cased the new way how to deal with
> submodules in ls-files.
>
> Cleanup the only remaining caller to repo_read_gitmodules outside of
> submodule.c

Well, submodule-config.c has its implementation and another caller, which technically is outside submodule.c ;-) repo_read_gitmodules has two more callers in unpack-trees.c these days, so perhaps we can do without this last paragraph.

Previous: Antonio OspiteNext: Junio C Hamano
Message 3 of 5 in “builtin/grep.c: remote superflous submodule code”
  1. builtin/grep.c: remote superflous submodule codeStefan Beller, Oct 5, 2018
  2. Antonio OspiteOct 6, 2018
  3. Junio C HamanoOct 7, 2018
  4. Junio C HamanoOct 7, 2018
  5. Stefan BellerOct 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.