Re: [PATCH] builtin/grep.c: remote superflous submodule code
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 7, 2018, 00:33 UTC
- Message-ID
- <xmqqh8hyvbnd.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20181005224557.31420-1-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
> After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules > file, 2017-08-03) this is no longer necessary, but that commit did not > cleanup the whole tree, but just show cased the new way how to deal with > submodules in ls-files.
The log message of the above one singles out "grep" as a special case and explalins why it did not touch, by the way. You probably need to explain the reason why "this is no longer necessary" a bit better than the above---as it stands, it is "ff6f1f564c4 said it still is necessary, I say it is not".