git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/1] t6300: format missing tagger

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2019, 18:05 UTC
Message-ID
<xmqqlfvloz2o.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190822162731.gxubrdro4imv55qs@shiar.net>
Mischa POSLAWSKY <git@shiar.nl> writes:
Show 19 quoted lines
> Junio wrote:
>> 
>> Mischa POSLAWSKY <git@shiar.nl> writes:
>> > Strip an annotated tag of its tagger header and verify it's ignored
>> > correctly in all cases, as fixed in commit e2a81276e8 (ref-filter:
>> > initialize empty name or email fields, 2019-08-19).
>> 
>> I am inclined to squash this test part of the update into the said
>> commit; you'd lose one commit count, but hopefully you do not mind?
>> 
>> My motivation for doing so is that it would allow us to lose the "as
>> fixed in commit X" comment in a log message, which in turn would
>> mean that the code-fix patch can later be rebased safely without
>> having to remember that this one needs to be adjusted ("git rebase"
>> does not do such a rewrite for us, and I personally do not think
>> "git rebase" should do such a rewrite silently, as I cannot quantify
>> the risk of false positives).
>
> Of course.  Might get one commit back if you pick it into maint :)

Actually you won't; I generally do not cherry-pick, even though I merge down relevant fixes to older maintenance tracks.

Previous: Mischa POSLAWSKY
Message 9 of 9 in “ref-filter: initialize empty name or email fields”
  1. ref-filter: initialize empty name or email fieldsMischa POSLAWSKY, Aug 17, 2019
  2. Junio C HamanoAug 19, 2019
  3. Junio C HamanoAug 20, 2019
  4. Mischa POSLAWSKYAug 22, 2019
  5. Junio C HamanoAug 21, 2019
  6. 2/1 t6300: format missing taggerMischa POSLAWSKY, Aug 22, 2019
  7. Junio C HamanoAug 22, 2019
  8. Mischa POSLAWSKYAug 22, 2019
  9. Junio C HamanoAug 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.