Re: [PATCH 2/1] t6300: format missing tagger
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 22, 2019, 16:15 UTC
- Message-ID
- <xmqq36htqipw.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190822135528.GB28725@shiar.net>
Mischa POSLAWSKY <git@shiar.nl> writes:
> Alright, thanks for the pointer. > Here's a batch of tests on all pertaining atoms.
Good to see that you made it much more thorough than my q-n-d illustration patch ;-)
Show 5 quoted lines
> -- >8 -- > > Strip an annotated tag of its tagger header and verify it's ignored > correctly in all cases, as fixed in commit e2a81276e8 (ref-filter: > initialize empty name or email fields, 2019-08-19).
I am inclined to squash this test part of the update into the said commit; you'd lose one commit count, but hopefully you do not mind?
My motivation for doing so is that it would allow us to lose the "as fixed in commit X" comment in a log message, which in turn would mean that the code-fix patch can later be rebased safely without having to remember that this one needs to be adjusted ("git rebase" does not do such a rewrite for us, and I personally do not think "git rebase" should do such a rewrite silently, as I cannot quantify the risk of false positives).
Show 36 quoted lines
> > Signed-off-by: Mischa POSLAWSKY <git@shiar.nl> > --- > t/t6300-for-each-ref.sh | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh > index ab69aa176d..9c910ce746 100755 > --- a/t/t6300-for-each-ref.sh > +++ b/t/t6300-for-each-ref.sh > @@ -526,6 +526,25 @@ test_expect_success 'Check ambiguous head and tag refs II (loose)' ' > test_cmp expected actual > ' > > +test_expect_success 'create tag without tagger' ' > + git tag -a -m "Broken tag" taggerless && > + git tag -f taggerless $(git cat-file tag taggerless | > + sed -e "/^tagger /d" | > + git hash-object --stdin -w -t tag) > +' > + > +test_atom refs/tags/taggerless type 'commit' > +test_atom refs/tags/taggerless tag 'taggerless' > +test_atom refs/tags/taggerless tagger '' > +test_atom refs/tags/taggerless taggername '' > +test_atom refs/tags/taggerless taggeremail '' > +test_atom refs/tags/taggerless taggerdate '' > +test_atom refs/tags/taggerless committer '' > +test_atom refs/tags/taggerless committername '' > +test_atom refs/tags/taggerless committeremail '' > +test_atom refs/tags/taggerless committerdate '' > +test_atom refs/tags/taggerless subject 'Broken tag' > + > test_expect_success 'an unusual tag with an incomplete line' ' > > git tag -m "bogo" bogo &&