Re: ds/commit-graph-on-fetch (was Re: What's cooking in git.git (Oct 2019, #07; Wed, 30))

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2019, 06:13 UTC
Message-ID: <xmqqlfsy3iwd.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <afec0f94-466a-2901-4dd7-528d0ae587fa@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 8 quoted lines

>> * ds/commit-graph-on-fetch (2019-10-25) 2 commits
>>   (merged to 'next' on 2019-10-30 at 3ca711f743)
>>  + commit-graph: fix writing first commit-graph during fetch
>>  + t5510-fetch.sh: demonstrate fetch.writeCommitGraph bug
>> 
>>  "git commit-grph write" hit BUG() in corner cases.
>
> s/grph/graph/

Thanks.

> I had thought this bugfix was worthy of making the release, as it
> may affect more users than I realized (anyone with a submodule, fetching
> after first clone).

Ah, I somehow mistook that this was a fix for an old corner case bug that has left undiscovered for some time, but writing commit graph after fetching is a fairly recent thing, so it is a regression fix.

Thanks.