ds/commit-graph-on-fetch (was Re: What's cooking in git.git (Oct 2019, #07; Wed, 30))

From: Derrick Stolee <stolee@gmail.com>
Date: Oct 30, 2019, 12:39 UTC
Message-ID: <afec0f94-466a-2901-4dd7-528d0ae587fa@gmail.com>
In-Reply-To: <xmqqd0ee3du9.fsf@gitster-ct.c.googlers.com>

On 10/30/2019 3:13 AM, Junio C Hamano wrote:

Show 8 quoted lines

> Here are the topics that have been cooking.  Commits prefixed with
> '-' are only in 'pu' (proposed updates) while commits prefixed with
> '+' are in 'next'.  The ones marked with '.' do not appear in any of
> the integration branches, but I am still holding onto them.
> 
> There is the v2.24.0-rc2 tag now; the contents of the release
> candidate hasn't changed much since the -rc1; hopefully we can see
> the final thing real soon now.

[snip]

Show 6 quoted lines

> * ds/commit-graph-on-fetch (2019-10-25) 2 commits
>   (merged to 'next' on 2019-10-30 at 3ca711f743)
>  + commit-graph: fix writing first commit-graph during fetch
>  + t5510-fetch.sh: demonstrate fetch.writeCommitGraph bug
> 
>  "git commit-grph write" hit BUG() in corner cases.

s/grph/graph/

>  Will cook in 'next'.

I had thought this bugfix was worthy of making the release, as it may affect more users than I realized (anyone with a submodule, fetching after first clone).

I understand if it is held back because it only affects a new feature that is opt-in for this release (the fetch.writeCommitGraph setting). Just wanted to check on the decision here.

Thanks, -Stolee