Re: [PATCH v2 0/3] Safer GIT_CURL_VERBOSE
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 13, 2020, 19:33 UTC
- Message-ID
- <xmqqlflvtysu.fsf@gitster.c.googlers.com>
- In-Reply-To
- <xmqqwo5ftz37.fsf@gitster.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Jonathan Tan <jonathantanmy@google.com> writes: > >> Thanks everyone. I went ahead with GIT_REDACT_AUTHORIZATION to match >> GIT_REDACT_COOKIES, with the default being true (i.e. you need to set it >> to "0" to have behavior change). > > Hmm, I would actually have expected us to move in the direction of > deprecating specific REDACT_BLAH and consolidate them into one, > instead of adding another one. Especially as the primary reason why > we redact cookies is to protect those that are used for auth anyway.
Also I had forgot to grep for anonymi.e to find transport_anonymize_url(), which I was hoping that the new environment variable would cover to help those who debug.
Thanks.