Re: [PATCH 1/2] t5551: test that GIT_TRACE_CURL redacts password
- From
Jeff King <peff@peff.net>
- Date
- May 12, 2020, 19:08 UTC
- Message-ID
- <20200512190831.GA54565@coredump.intra.peff.net>
- In-Reply-To
- <bee4fc7241596a6b4206fa8b52dfdaea88180f37.1589218693.git.jonathantanmy@google.com>
On Mon, May 11, 2020 at 10:43:09AM -0700, Jonathan Tan wrote:
> Verify that when GIT_TRACE_CURL is set, Git prints out "Authorization: > Basic <redacted>" instead of the base64-encoded authorization details.
Yeah, it's definitely worth testing this. The patch looks good to me.
-Peff