git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] refspec: make @ a synonym of HEAD

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 26, 2020, 00:01 UTC
Message-ID
<xmqqlfepasvg.fsf@gitster.c.googlers.com>
In-Reply-To
<CAMP44s2cpPgg55XHTr=cRqRcrMOkU=qcrM=RpWYwVJJdd9V4JA@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 8 quoted lines
> On Tue, Nov 24, 2020 at 7:53 PM Junio C Hamano <gitster@pobox.com> wrote:
>> ...
>> we care about both of these forms working, not just the singleton
>> form, so it is not just "not hurt", but is actively a good thing, to
>> protect both forms from future breakage.  After all, that is why we
>> have tests.
>
> Both forms were already tested.

Yeah, I did realize it in my review of reviews I do after sending all the messages yesterday (not just on this topic), so there is no strong reason to duplicate all the tests that involve HEAD.

Thanks for pushing back on this point.
Previous: Felipe Contreras
Message 6 of 6 in “refspec: make @ a synonym of HEAD”
  1. refspec: make @ a synonym of HEADFelipe Contreras, Nov 25, 2020
  2. Junio C HamanoNov 25, 2020
  3. Felipe ContrerasNov 25, 2020
  4. Junio C HamanoNov 25, 2020
  5. Felipe ContrerasNov 25, 2020
  6. Junio C HamanoNov 26, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.