Re: [PATCH v2] refspec: make @ a synonym of HEAD

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 25, 2020, 00:43 UTC
Message-ID: <CAMP44s2ChcCjhjksS0s5BoYznqLAoXyFvSkP4GxSCh_ALusOtQ@mail.gmail.com>
In-Reply-To: <xmqqblfmgtlg.fsf@gitster.c.googlers.com>

On Tue, Nov 24, 2020 at 6:37 PM Junio C Hamano <gitster@pobox.com> wrote:

> Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 13 quoted lines

> > +test_expect_success 'push with @' '
> > +
> > +     mk_test testrepo heads/master &&
> > +     git checkout master &&
> > +     git push testrepo @ &&
> > +     check_push_result testrepo $the_commit heads/master
> > +
> > +'
>
> This is OK, but shouldn't this be placed before the tests with
> various configuration?  Something along the lines of the attached,
> but with the body of the loop properly reindented, would also give
> us a better test coverage at the same time.

I don't see much value in those tests, since I don't see how if one passes another one would fail. But I guess it cannot hurt.

-- 
Felipe Contreras