Re: [PATCH] t6016: move to lib-log-graph.sh framework

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2021, 20:55 UTC
Message-ID: <xmqqlfd5rdja.fsf@gitster.c.googlers.com>
In-Reply-To: <d01e2830-d579-67c6-1076-ed44cff27ad7@aerusso.net>

Antonio Russo <aerusso@aerusso.net> writes:

Show 6 quoted lines

> You are correct that the A4 and A6 tags can be removed without affecting
> the output.  In fact, A4 is basically immediately deleted (in the second test).
> I can remove that, if we want to stop testing the tag deletion logic here.
> I suppose that is sufficiently validated elsewhere in the test suite.
>
> There's a (weak IMO) argument to keep the A6 tag, since ...

I see.  Thanks for explaining.

Show 5 quoted lines

> My guiding principle when I made this patch was to be as minimally invasive
> as possible, while allowing modifications to this file to be pleasant---which
> I must admit is my ulterior motive.
>
> I can certainly remove these "extraneous" tags if desired.

I actually am _for_ keeping these tags. It is just that I want to see the reason why these tags, some of which are no longer needed for the purpose of matching the output with expectation, are kept explained in the proposed log message.

Thanks.