Re: [PATCH] t6016: move to lib-log-graph.sh framework
- From
Antonio Russo <aerusso@aerusso.net>
- Date
- Jan 5, 2021, 00:59 UTC
- Message-ID
- <b147caf4-de4c-dc2c-ec3d-6efd611becf5@aerusso.net>
- In-Reply-To
- <X/K1BgP8tpsgNe2x@Abhishek-Arch>
On 1/3/21 11:26 PM, Abhishek Kumar wrote:
Show 11 quoted lines
> > Glad to see others using `lib-log-graph.sh` as well! > > The changes look alright to me but maybe you could have split the two > changes into two different commits: Using tags directly instead of > environment variables and using `check_graph` instead of manually > `echo`-ing to an expected output and comparing with the actual output. > > Other contributors would have a better idea whether it's truly required > or not. >
Thanks for the feedback! I can split this patch in two if that's desired.
[snip]
> > Thanks > - Abhishek >
Best, Antonio