git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t6016: move to lib-log-graph.sh framework

From
Antonio Russo <aerusso@aerusso.net>
Date
Jan 5, 2021, 00:59 UTC
Message-ID
<b147caf4-de4c-dc2c-ec3d-6efd611becf5@aerusso.net>
In-Reply-To
<X/K1BgP8tpsgNe2x@Abhishek-Arch>
On 1/3/21 11:26 PM, Abhishek Kumar wrote:
Show 11 quoted lines
> 
> Glad to see others using `lib-log-graph.sh` as well!
> 
> The changes look alright to me but maybe you could have split the two
> changes into two different commits: Using tags directly instead of
> environment variables and using `check_graph` instead of manually
> `echo`-ing to an expected output and comparing with the actual output.
> 
> Other contributors would have a better idea whether it's truly required
> or not.
> 
Thanks for the feedback!  I can split this patch in two if that's desired.
[snip]
> 
> Thanks
> - Abhishek
> 

Best, Antonio

Previous: Abhishek KumarNext: Junio C Hamano
Message 3 of 7 in “t6016: move to lib-log-graph.sh framework”
  1. t6016: move to lib-log-graph.sh frameworkAntonio Russo, Jan 4, 2021
  2. Abhishek KumarJan 4, 2021
  3. Antonio RussoJan 5, 2021
  4. Junio C HamanoJan 6, 2021
  5. Antonio RussoJan 6, 2021
  6. Junio C HamanoJan 6, 2021
  7. t6016: move to lib-log-graph.sh frameworkAntonio Russo, Jan 10, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.