Re: [PATCH v2 00/12] doc: cleanup old cruft and asciidoctor revamp
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 25, 2021, 06:59 UTC
- Message-ID
- <xmqqlf83fge2.fsf@gitster.g>
- In-Reply-To
- <60abfd46a8ca3_1b20920823@natae.notmuch>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Apparently my scripts call `git format-patch` with -D, which doesn't > generate appliable patches when files are deleted.
Don't call format-patch with -D, then ;-).
> Do you want me to send it again without -D?
Sure, if a collection of patches want to be reviewed and applied, I would think it helps for them to be appliable to a common tree (like my 'master') with tools reviewers and the maintainer are know to use (like "git am"). As more roadblocks are added before the changes can become reviewable in the reviewers' trees, less chances they have to get reviewed.