git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 05/12] doc: asciidoctor: remove unnecessary require

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 21, 2021, 22:36 UTC
Message-ID
<20210521223701.526547-6-felipe.contreras@gmail.com>
In-Reply-To
<20210521223701.526547-1-felipe.contreras@gmail.com>
This file is loaded by asciidoctor, the module is already loaded.

In addition to being less redundant this fixes a problem while trying use a development version of asciidoctor when the gem is available:

  $GEM_HOME/gems/asciidoctor-2.0.15/lib/asciidoctor.rb:51:
    warning: already initialized constant Asciidoctor::RUBY_ENGINE
  $HOME/asciidoctor/lib/asciidoctor.rb:52:
    warning: previous definition of RUBY_ENGINE was here
  ...
That's a bug in asciidoctor, but there's no need to trigger it.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 Documentation/asciidoctor-extensions.rb | 1 -
 1 file changed, 1 deletion(-)
diff --git a/Documentation/asciidoctor-extensions.rb b/Documentation/asciidoctor-extensions.rb
index 70a0956663..423450392d 100644
--- a/Documentation/asciidoctor-extensions.rb
+++ b/Documentation/asciidoctor-extensions.rb
@@ -1,4 +1,3 @@
-require 'asciidoctor'
 require 'asciidoctor/extensions'
 
 module Git
-- 
2.32.0.rc0
Previous: Felipe ContrerasNext: Felipe Contreras
Message 6 of 18 in “doc: cleanup old cruft and asciidoctor revamp”
  1. 00/12 doc: cleanup old cruft and asciidoctor revampFelipe Contreras, May 21, 2021
  2. 01/12 doc: remove GNU troff workaroundFelipe Contreras, May 21, 2021
  3. 02/12 doc: use --stringparam in xmltoFelipe Contreras, May 21, 2021
  4. 03/12 doc: simplify version passingFelipe Contreras, May 21, 2021
  5. 04/12 doc: asciidoc: remove unnecessary attributeFelipe Contreras, May 21, 2021
  6. 05/12 doc: asciidoctor: remove unnecessary requireFelipe Contreras, May 21, 2021
  7. 06/12 doc: asciidoctor: remove cruftFelipe Contreras, May 21, 2021
  8. 07/12 doc: asciidoctor: reorganize extensionsFelipe Contreras, May 21, 2021
  9. 08/12 doc: asciidoctor: use html-prefix only for htmlFelipe Contreras, May 21, 2021
  10. 09/12 doc: asciidoctor: refactor macro registrationFelipe Contreras, May 21, 2021
  11. 10/12 doc: asciidoctor: improve string handlingFelipe Contreras, May 21, 2021
  12. 11/12 doc: asciidoctor: split the format from the codeFelipe Contreras, May 21, 2021
  13. 12/12 doc: asciidoctor: specify name of our groupFelipe Contreras, May 21, 2021
  14. Junio C HamanoMay 24, 2021
  15. Felipe ContrerasMay 24, 2021
  16. Junio C HamanoMay 25, 2021
  17. Junio C HamanoMay 25, 2021
  18. Felipe ContrerasMay 25, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.