Re: [PATCH] builtin/repack.c: remove redundant pack-based bitmaps
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 17, 2022, 21:04 UTC
- Message-ID
- <xmqqlepeyxf6.fsf@gitster.g>
- In-Reply-To
- <Y02shQFeXkwYd2g6@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Really, both here and remove_redundant_pack() should probably be using > unlink_or_warn(). Though if you did want to notice the race on deleting > the actual .pack file, it would need to be hand-coded.
Yeah, unlink_or_warn() would probably be the right way to go.
Other than that, the patch looks good to you folks?
Thanks.