git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/repack.c: remove redundant pack-based bitmaps

From
Jeff King <peff@peff.net>
Date
Oct 17, 2022, 21:40 UTC
Message-ID
<Y03L0W6TadyhtDij@coredump.intra.peff.net>
In-Reply-To
<xmqqlepeyxf6.fsf@gitster.g>
On Mon, Oct 17, 2022 at 02:04:13PM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Really, both here and remove_redundant_pack() should probably be using
> > unlink_or_warn(). Though if you did want to notice the race on deleting
> > the actual .pack file, it would need to be hand-coded.
> 
> Yeah, unlink_or_warn() would probably be the right way to go.
> 
> Other than that, the patch looks good to you folks?

Yeah. I suggested a minor reordering of the one change, but the substance of the patch looks good to me (and I am OK either way on the little suggestions).

-Peff
Previous: Junio C HamanoNext: Taylor Blau
Message 6 of 10 in “builtin/repack.c: remove redundant pack-based bitmaps”
  1. builtin/repack.c: remove redundant pack-based bitmapsTaylor Blau, Oct 12, 2022
  2. Jeff KingOct 17, 2022
  3. Ævar Arnfjörð BjarmasonOct 17, 2022
  4. Jeff KingOct 17, 2022
  5. Junio C HamanoOct 17, 2022
  6. Jeff KingOct 17, 2022
  7. Taylor BlauOct 18, 2022
  8. Taylor BlauOct 18, 2022
  9. builtin/repack.c: remove redundant pack-based bitmapsTaylor Blau, Oct 18, 2022
  10. Jeff KingOct 18, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.