git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] am: Allow passing --no-verify flag

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 1, 2022, 00:55 UTC
Message-ID
<xmqqlenst021.fsf@gitster.g>
In-Reply-To
<xmqqr0xkt07x.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> ...
> The same comment as the previous one applies to "test_cmp_rev second"
> check.  I think removing them would make the tests better.
I will queue this on top for now.  Thanks.
 t/t4150-am.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git i/t/t4150-am.sh w/t/t4150-am.sh
index d77c4dcefe..50b257e43f 100755
--- i/t/t4150-am.sh
+++ w/t/t4150-am.sh
@@ -356,7 +356,6 @@ test_expect_success 'am with failing applypatch-msg hook (no verify)' '
 	git am --no-verify patch1 &&
 	test_path_is_missing .git/rebase-apply &&
 	git diff --exit-code second &&
-	test_cmp_rev second HEAD &&
 	git log -1 --format=format:%B >actual &&
 	test_cmp msg actual
 '
@@ -401,9 +400,10 @@ test_expect_success 'am with failing pre-applypatch hook (no verify)' '
 	EOF
 	git am --no-verify patch1 &&
 	test_path_is_missing .git/rebase-apply &&
+	test_path_is_file empty-file &&
 	git diff --exit-code second &&
-	test_cmp_rev second HEAD &&
-	test_path_is_file empty-file
+	git log -1 --format=format:%B >actual &&
+	test_cmp msg actual
 '
 
 test_expect_success 'am with post-applypatch hook' '
Previous: Junio C HamanoNext: Thierry Reding
Message 3 of 7 in “am: Allow passing --no-verify flag”
  1. am: Allow passing --no-verify flagThierry Reding, Nov 30, 2022
  2. Junio C HamanoDec 1, 2022
  3. Junio C HamanoDec 1, 2022
  4. Thierry RedingDec 21, 2022
  5. Junio C HamanoDec 21, 2022
  6. Thierry RedingDec 21, 2022
  7. Junio C HamanoDec 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.