Re: [PATCH 3/3] scalar: only warn when background maintenance fails

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 27, 2023, 20:36 UTC
Message-ID: <xmqqleln90ka.fsf@gitster.g>
In-Reply-To: <d75780e0567b5f765816ab7522afe550ebaa3521.1674849963.git.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 18 quoted lines

> From: Derrick Stolee <derrickstolee@github.com>
>
> A user reported issues with 'scalar clone' and 'scalar register' when
> working in an environment that had locked down the ability to run
> 'crontab' or 'systemctl' in that those commands registered as _failures_
> instead of opportunistically reporting a success with just a warning
> about background maintenance.
>
> As a workaround, they can use GIT_TEST_MAINT_SCHEDULER to fake a
> successful background maintenance, but this is not a viable strategy for
> long-term.
>
> Update 'scalar register' and 'scalar clone' to no longer fail by
> modifying register_dir() to only warn when toggle_maintenance(1) fails.
>
> Since background maintenance is a "nice to have" and not a requirement
> for a working repository, it is best to move this from hard error to
> gentle warning.

Wasn't the main selling point of scalar that users do not have to worry about various minute details of configuration settings to maintain their clone of projects on the larger side? The "maintain their clone" certainly should include running periodic maintenance tasks without them having to worry about it. It feels like this is calling for an explicit "disable periodic maintenance tasks in this repository" option to help these esoteric environments that disable cron-like system services, while keeping the default safer, i.e. fail loudly when the periodic maintenance tasks that the users expect to happen cannot be enabled, or something.

Perhaps I am not the primary audience, but hmph, I have a feeling that this is not exactly going into a healthy direction.

Other two steps that led to this step looked quite sensible, though.

Thanks.