Re: CMakeLists.txt from contrib/buildsystems fails to build on Mac

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2023, 16:53 UTC
Message-ID: <xmqqlel8t7xw.fsf@gitster.g>
In-Reply-To: <a120ea47-722d-2bb0-9c49-294a850af6af@dunelm.org.uk>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 7 quoted lines

> On 08/02/2023 11:57, Ævar Arnfjörð Bjarmason wrote:
>> Or rather, that GFW would be fixing it up, but then I don't see why it
>> should be in git.git, which as your message shows just leads to
>> confusion about why this component is in git.git's tree.
>
> I think Ilya's message shows we need to update the instructions in
> CMakeLists.txt to make it clear it is Windows only.

That matches the conclusion in the thread

  https://lore.kernel.org/git/1e701a54-0356-9f55-ab53-9d8bfdd93e55@dunelm.org.uk/

which was a subthread of the primary discussion we had on this topic, which starts here:

  https://lore.kernel.org/git/544fff8a-7d56-57a1-00a3-d1a9302e227c@dunelm.org.uk/

I am fine with either marking CMakeLists as windows-only, or removing it from my tree and have GfW folks add it back to their tree.

Or keep it in my tree, make CI failures around it "soft" failures, and mark it prominently as "work in progress" on platforms other than Windows. But this choice is only valid if we as the project want to expend more effort on enhancing and extending cmake support. I personally do not believe in having to maintain two parallel build systems for non Windows and keep them in sync.