Re: CMakeLists.txt from contrib/buildsystems fails to build on Mac
- From
Ilya Kantor <iliakan@gmail.com>
- Date
- Feb 8, 2023, 14:34 UTC
- Message-ID
- <68C6062A-7833-48F2-8F44-3BB129E5E9E5@gmail.com>
- In-Reply-To
- <a120ea47-722d-2bb0-9c49-294a850af6af@dunelm.org.uk>
Hi,
Thank you for the responses.
Yes, I saw the discussion, but couldn't figure out the final outcome.
Indeed, I'd suggest to remove the mention of any other platforms if it's windows-only.
And if it's windows-only, then it makes sense to move it to git-for-windows, at least for a bird's-eye view.
Kind regards, Ilya Kantor
Show 14 quoted lines
> On 8 Feb 2023, at 15:31, Phillip Wood <phillip.wood123@gmail.com> wrote: > > Hi Ævar > > On 08/02/2023 11:57, Ævar Arnfjörð Bjarmason wrote: >> Or rather, that GFW would be fixing it up, but then I don't see why it >> should be in git.git, which as your message shows just leads to >> confusion about why this component is in git.git's tree. > > I think Ilya's message shows we need to update the instructions in CMakeLists.txt to make it clear it is Windows only. > > Best Wishes > > Phillip