Re: [PATCH v2 0/5] hook API: support stdin, convert post-rewrite
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 18 quoted lines
> As noted in the v1[1] this is the initial part of the greater
> "config-based hooks" topic. I believe this iteration addresses all
> comments on v1. Changes since then:
>
> * Remove a couple of paragraphs in 1/4 that aren't relevant anymore,
> an already-landed topic addressed those.
>
> * Don't needlessly change "cp->no_stdin = 1" and introduce an
> "else". This refactoring was there because that code eventually
> changes in the full "config-based hooks" topic, but going through
> those future changes I found that it wasn't for a good reason there
> either. We can just keep the "no_stdin = 1" by default, and have
> specific cases override that.
>
> * Elaborate on why we're not converting the last "post-rewrite" hook
> here.
>
> * Mention the future expected use for sendemail-validate in 5/5
All read well. Will queue. Thanks.