[PATCH 1/5] run-command.c: remove dead assignment in while-loop
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jan 23, 2023, 17:15 UTC
- Message-ID
- <patch-1.5-351c6a55a41-20230123T170551Z-avarab@gmail.com>
- In-Reply-To
- <cover-0.5-00000000000-20230123T170550Z-avarab@gmail.com>
Remove code that's been unused since it was added in c553c72eed6 (run-command: add an asynchronous parallel child processor, 2015-12-15), the next use of "i" in this function is:
for (i = 0; ...
So we'll always clobber the "i" that's set here. Presumably the "i" assignment is an artifact of WIP code that made it into our tree.
A subsequent commit will need to adjust the type of the "i" variable in the otherwise unrelated for-loop, which is why this is being removed now.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- run-command.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/run-command.c b/run-command.c index 50cc011654e..b439c7974ca 100644 --- a/run-command.c +++ b/run-command.c @@ -1632,9 +1632,7 @@ static void pp_buffer_stderr(struct parallel_processes *pp, const struct run_process_parallel_opts *opts, int output_timeout) { - int i; - - while ((i = poll(pp->pfd, opts->processes, output_timeout) < 0)) { + while (poll(pp->pfd, opts->processes, output_timeout) < 0) { if (errno == EINTR) continue; pp_cleanup(pp, opts);
-- 2.39.1.1301.gffb37c08dee