Re: [PATCH v3 2/4] transport-helper: call do_take_over() in process_connect

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2023, 18:29 UTC
Message-ID: <xmqqlecip7gx.fsf@gitster.g>
In-Reply-To: <e3dc18caa91bd16d95dc7c2bbd0e6eceedefe636.1696432594.git.zhiyou.jx@alibaba-inc.com>

Jiang Xin <worldhello.net@gmail.com> writes:

> It is safe to make a refactor by moving the call of do_take_over()
> into the function process_connect().

"It is safe" only explains why it does not hurt, and does not explain why it is a good idea to do so, though.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.