Re: [PATCH v2] apply: add unit tests for parse_range

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 6, 2024, 17:24 UTC
Message-ID: <xmqqle3im1bx.fsf@gitster.g>
In-Reply-To: <pull.1677.v2.git.git.1716710073910.gitgitgadget@gmail.com>

"Philip Peterson via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> From: Philip Peterson <philip.c.peterson@gmail.com>
>
> Also rename parse_range to parse_fragment_range for external linkage.
>
> Signed-off-by: Philip Peterson <philip.c.peterson@gmail.com>
> ---

This version saw no reviews (unfortunately).

I just gave another quick glance, did not spot anything glaringly wrong, and the way the tests are organized as a series of ...

Show 8 quoted lines

> +	TEST(setup_static((struct test_case) {
> +		.line = "@@ -4,4",
> +		.offset = -1,
> +		.expect_suffix = " +",
> +		.expect_result = FAILURE,
> +		.expect_p1 = 9999,
> +		.expect_p2 = 9999
> +	}), "negative offset");

... rather pleasant to read. I'd admit that it does not count as a proper review, though.

Thanks.