Re: [GSoC PATCH 0/3] receive-pack: fix HEAD check for updateInstead
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 31, 2026, 22:21 UTC
- Message-ID
- <xmqqldf7wsh1.fsf@gitster.g>
- In-Reply-To
- <20260330111822.165188-1-pabloosabaterr@gmail.com>
Pablo Sabater <pabloosabaterr@gmail.com> writes:
Show 7 quoted lines
> This series includes Runxi's test, a cleanup of a test that messes with Runxi's > test and the fix for the issue. > > Pablo Sabater (2): > t5516: clean up cloned and new-wt in denyCurrentBranch and worktrees > test > receive-pack: use worktree HEAD for updateInstead
I re-read the main patch [3/3]; we used to check "HEAD" in the_repository but now we pass the worktree object (not just its "path" member) down the callchain, and that allows us to check if the worktree's HEAD is unborn. Which makes sense and is a surprisingly small fix.
Let me mark the topic for 'next'. Thanks.
Show 10 quoted lines
> > Runxi Yu (1): > t5516: test updateInstead with worktree and unborn bare HEAD > > builtin/receive-pack.c | 39 +++++++++++++++------------------------ > t/t5516-fetch-push.sh | 15 +++++++++++++++ > 2 files changed, 30 insertions(+), 24 deletions(-) > > > base-commit: ca1db8a0f7dc0dbea892e99f5b37c5fe5861be71