git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH 0/3] receive-pack: fix HEAD check for updateInstead

From
Pablo <pabloosabaterr@gmail.com>
Date
Mar 30, 2026, 18:49 UTC
Message-ID
<CAN5EUNRYpzbT58jAaheBVNG_jxVFJy5a=r_v7gREPyspQ8zTyw@mail.gmail.com>
In-Reply-To
<xmqqy0j9e3t9.fsf@gitster.g>
Junio C Hamano (<gitster@pobox.com>) writes:
Show 21 quoted lines
>
> Pablo Sabater <pabloosabaterr@gmail.com> writes:
>
> > When a bare repo has linked worktrees, and its HEAD points to an unborn branch,
> > pushing to a wt branch with updateInstead fails and rejects the push, even if
> > the wt is clean.
> >
> > This happens because HEAD is checked only for the bare repo context, instead
> > of the wt.
> >
> > This series includes Runxi's test, a cleanup of a test that messes with Runxi's
> > test and the fix for the issue.
>
> It would have made a perfect cover letter if you said in a very
> early paragraph what Runxi is and how it related to this issue.  I
> am guessing (from the fact that the same word appears in the patch
> list below with family name) that is a name of a person who first
> reported the issue?  If so, the missing sentence would have said
> something like "At https/lore.kernel.org/git/$MessageId, Runxi Yu
> reported ...".
>

I thought that by sending the series in-reply to the original Runxi's report it wouldn't be needed. But yeah, it isn't clear if someone would only read the cover letter.

this is Runxi's original report which is the parent of this thread:
  https://lore.kernel.org/git/20260223141236.22476-1-me@runxiyu.org/
Thanks for the feedback :)
Show 18 quoted lines
> I have to leave the keyboard now, so will take a look at the patches
> later today.  Thanks.
>
>
> > Pablo Sabater (2):
> >   t5516: clean up cloned and new-wt in denyCurrentBranch and worktrees
> >     test
> >   receive-pack: use worktree HEAD for updateInstead
> >
> > Runxi Yu (1):
> >   t5516: test updateInstead with worktree and unborn bare HEAD
> >
> >  builtin/receive-pack.c | 39 +++++++++++++++------------------------
> >  t/t5516-fetch-push.sh  | 15 +++++++++++++++
> >  2 files changed, 30 insertions(+), 24 deletions(-)
> >
> >
> > base-commit: ca1db8a0f7dc0dbea892e99f5b37c5fe5861be71
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 11 in “t5516: test updateInstead with worktree and unborn bare HEAD”
  1. t5516: test updateInstead with worktree and unborn bare HEADRunxi Yu, Feb 23, 2026
  2. Junio C HamanoFeb 23, 2026
  3. Runxi YuFeb 24, 2026
  4. Runxi YuMar 3, 2026
  5. 0/3 receive-pack: fix HEAD check for updateInsteadPablo Sabater, Mar 30, 2026
  6. 1/3 t5516: test updateInstead with worktree and unborn bare HEADPablo Sabater, Mar 30, 2026
  7. 2/3 t5516: clean up cloned and new-wt in denyCurrentBranch and worktrees testPablo Sabater, Mar 30, 2026
  8. 3/3 receive-pack: use worktree HEAD for updateInsteadPablo Sabater, Mar 30, 2026
  9. Junio C HamanoMar 30, 2026
  10. PabloMar 30, 2026
  11. Junio C HamanoMar 31, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.