Re: [PATCH] commit-reach: parse commits in the given repository
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 16, 2026, 17:48 UTC
- Message-ID
- <xmqqld91w0ia.fsf@gitster.g>
- In-Reply-To
- <20260916134632.1424829-1-orestisflo@gmail.com>
Orestis Floros <orestisflo@gmail.com> writes:
Show 11 quoted lines
> ... > The latter used to be the only symptom. Before bb5da75d61 (commit: use > commit graph in `lookup_commit_reference_gently()`, 2026-02-16) the > initial lookup did not record commit-graph positions, so the walk simply > failed to find the submodule commits in the superproject: > > error: Could not read <commit> > Failed to merge submodule sub (commits don't follow merge-base) > > Pass the repository into both functions. git-fetch-pack(1) and > git-upload-pack(1) keep passing `the_repository`.
That's reasonable. It is a very welcome change that aligns with recent libification efforts.
Will queue.
Thanks.