git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 5, 2013, 23:14 UTC
Message-ID
<xmqqk3iug8sz.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20130905190249.GA1532@dcvr.yhbt.net>
Eric Wong <normalperson@yhbt.net> writes:
Show 25 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
>> "Uli Heller" <uli.heller@daemons-point.com> writes:
>> > Nevertheless, I think it makes sense to fix the issue within the
>> > git perl module Ra.pm, too. The change frees the private copy of
>> > the remote access object on termination which prevents the error
>> > from happening.
>
>> Thanks.  Please sign-off your patch.
>> 
>> I am Cc'ing Kyle McKay who apparently had some experience working
>> with git-svn with newer svn that can only use serf, hoping that we
>> can get an independent opinion/test just to be sure.  Also Cc'ed is
>> Eric Wong who has been the official git-svn area expert, but I
>> understand that Eric hasn't needed to use git-svn for quite a while,
>> so it is perfectly fine if he does not have any comment on this one.
>> 
>> We may want to find a volunteer to move "git svn" forward as a new
>> area expert (aka subsystem maintainer), by the way.
>
> Correct, git-svn has the effect of being self-obsoleting.
>
> I agree with adding a workaround for broken things, however
> I suggest a code comment explaining why it is necessary.
> The commit message is important, too, but might get harder to track
> down if there's code movement/refactoring in the future.

Thanks for a good suggestion. I agree that this addition is a good example where in-code comment would really help the future readers.

Show 5 quoted lines
>
>> > +END {
>> > +	$RA = undef;
>> > +	$ra_invalid = 1;
>> > +}
Previous: Eric WongNext: Kyle J. McKay
Message 4 of 12 in “git-svn: Fix termination issues for remote svn connections”
  1. git-svn: Fix termination issues for remote svn connectionsUli Heller, Sep 3, 2013
  2. Junio C HamanoSep 5, 2013
  3. Eric WongSep 5, 2013
  4. Junio C HamanoSep 5, 2013
  5. Kyle J. McKaySep 6, 2013
  6. Uli HellerSep 6, 2013
  7. Kyle J. McKaySep 6, 2013
  8. Uli HellerSep 6, 2013
  9. Junio C HamanoSep 6, 2013
  10. git-svn: Fix termination issues for remote svn connectionsUli Heller, Sep 9, 2013
  11. Junio C HamanoSep 9, 2013
  12. Kyle J. McKaySep 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.