[PATCH v2] git-svn: Fix termination issues for remote svn connections

From: Uli Heller <uli.heller@daemons-point.com>
Date: Sep 9, 2013, 06:01 UTC
Message-ID: <522D643E.2000901@daemons-point.com>
In-Reply-To: <xmqqa9jpzyvo.fsf@gitster.dls.corp.google.com>

 From a763550fc59b756580f9b162839d2737c27f2fe3 Mon Sep 17 00:00:00 2001
From: Uli Heller <uli.heller@daemons-point.com>
Date: Tue, 3 Sep 2013 09:14:03 +0200
Subject: [PATCH] git-svn: Fix termination issues for remote svn connections

When using git-svn in combination with serf-1.2.1 core dumps are created on termination. This is caused by a bug in serf, a fix for the bug exists (see https://code.google.com/p/serf/source/detail?r=2146). Nevertheless, I think it makes sense to fix the issue within the git perl module Ra.pm, too. The change frees the private copy of the remote access object on termination which prevents the error from happening.

Note: Since subversion-1.8.0 and later do require serf-1.2.1 or later,
the core dumps typically do show up when upgrading to a recent version
of subversion.

Credits: Jonathan Lambrechts for proposing a fix to Ra.pm.
Evgeny Kotkov and Ivan Zhakov for fixing the issue in serf and
pointing me to that fix.
Junio C Hamano for proposing a great code comment.
Kyle J. McKay for testing against latest serf (1.3.1).
... and various others - thanks!
---
  perl/Git/SVN/Ra.pm | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
index 75ecc42..a7b0119 100644
--- a/perl/Git/SVN/Ra.pm
+++ b/perl/Git/SVN/Ra.pm
@@ -32,6 +32,14 @@ BEGIN {
         }
  }

+# serf has a bug that leads to a coredump upon termination if the
+# remote access object is left around (not fixed yet in serf 1.3.1).
+# Explicitly free it to work around the issue.
+END {
+       $RA = undef;
+       $ra_invalid = 1;
+}
+
  sub _auth_providers () {
         my @rv = (
           SVN::Client::get_simple_provider(),

-- 
1.8.4