git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: mktree: multiple same-named objects

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 27, 2014, 15:17 UTC
Message-ID
<xmqqk35uezd0.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140827051341.GB32141@peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> On Wed, Aug 27, 2014 at 12:41:57AM -0400, David Turner wrote:
>
>> git mktree seems to allow the creation of a tree object with multiple
>> objects of the same name but different SHAs.
>
> Yeah, I don't think we do many quality checks there. Ditto for "git
> hash-object".

I am somewhat against outright removing the capability to write out invalid objects deliberately from these low level tools, because we would need a way to easily reproduce bugs in end-user facing tools by other people who claim to produce Git objects, but I would agree that by default that should be forbidden.

In other words, two things must happen; improve checks when these low level debugging aid tools are creating objects, and allow bypassing these additional checks with "--experiment" option or something.

Previous: Jeff KingNext: Jeff King
Message 5 of 6 in “mktree: multiple same-named objects”
  1. David TurnerAug 27, 2014
  2. Duy NguyenAug 27, 2014
  3. David TurnerAug 27, 2014
  4. Jeff KingAug 27, 2014
  5. Junio C HamanoAug 27, 2014
  6. Jeff KingAug 27, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.