From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 27 Aug 2014 15:17:15 GMT
Subject: Re: mktree: multiple same-named objects
Message-ID: <xmqqk35uezd0.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140827051341.GB32141@peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Aug 27, 2014 at 12:41:57AM -0400, David Turner wrote:
>
>> git mktree seems to allow the creation of a tree object with multiple
>> objects of the same name but different SHAs.
>
> Yeah, I don't think we do many quality checks there. Ditto for "git
> hash-object".

I am somewhat against outright removing the capability to write out
invalid objects deliberately from these low level tools, because we
would need a way to easily reproduce bugs in end-user facing tools
by other people who claim to produce Git objects, but I would agree
that by default that should be forbidden.

In other words, two things must happen; improve checks when these
low level debugging aid tools are creating objects, and allow
bypassing these additional checks with "--experiment" option or
something.