git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] blame: add blame.showemail config option

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2015, 21:43 UTC
Message-ID
<xmqqk2wtxpg5.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAPig+cQ1JNeg5eoJib07nc6UrREE80pssokbk+xthXTXDcQz1g@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 15 quoted lines
> On Thu, Apr 30, 2015 at 10:03 AM, Quentin Neill <quentin.neill@gmail.com> wrote:
>> I'm thinking of a test file that will test all the git blame options,
>> but for this
>> patch it will only test the new showEmail config.  I read t/README and
>> tentatively named the new test file "t/8009-blame-config.sh".
>
> I'm not sure that these new proposed tests warrant a new test script.
> Moreover, the tests presumably will be testing combinations of
> configuration options and command-line switches, so having "config" in
> the script name doesn't seem quite correct.
>
> t8002-blame.sh already contains a test for --show-email, so it may be
> logical to add the new tests there, alongside the existing one. On the
> other hand, if you do add a new test script, then perhaps the existing
> --show-email test in t8002-blame.sh should be moved to the new script.

Good thinking. I would vote for the former, unless the number of additional tests exceed 20 (as t8002 has about 100 tests).

Previous: Eric SunshineNext: Eric Sunshine
Message 10 of 17 in “blame: add blame.showemail config option”
  1. blame: add blame.showemail config optionQuentin Neill, Apr 24, 2015
  2. Eric SunshineApr 24, 2015
  3. Quentin NeillApr 27, 2015
  4. Junio C HamanoApr 27, 2015
  5. Eric SunshineApr 27, 2015
  6. Junio C HamanoApr 28, 2015
  7. Quentin NeillApr 30, 2015
  8. Junio C HamanoApr 30, 2015
  9. Eric SunshineApr 30, 2015
  10. Junio C HamanoApr 30, 2015
  11. Eric SunshineApr 27, 2015
  12. Junio C HamanoMay 29, 2015
  13. Quentin NeillMay 30, 2015
  14. blame: add blame.showEmail configurationQuentin Neill, May 30, 2015
  15. Junio C HamanoMay 31, 2015
  16. Quentin NeillMay 31, 2015
  17. blame: add blame.showEmail configurationQuentin Neill, May 31, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.