git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] blame: add blame.showemail config option

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2015, 16:10 UTC
Message-ID
<xmqq1tj138cf.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CACfD1vtfO_rqr4wv4oHm7W7DSn-Gk-du6nCuJzYvpPXK_d=y=g@mail.gmail.com>
Quentin Neill <quentin.neill@gmail.com> writes:
Show 8 quoted lines
> On Fri, Apr 24, 2015 at 12:22 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> Despite being case-insensitive and despite existing inconsistencies,
>> in documentation, it is customary to use camelCase for configuration
>> options, so "blame.showEmail".
>
> I noticed while testing that git_config()/git_value() lowercase
> everything, so to be clear this camelCase custom for configuration
> names is for documentation only, right?

Correct. Write "section.variableName" in documentation and invocations of "git config" command in scripts. Compare key with "section.variablename" in git_config() callback.

> I'm thinking of a test file that will test all the git blame options,
> but for this
> patch it will only test the new showEmail config.  I read t/README and
> tentatively named the new test file "t/8009-blame-config.sh".
I'd suggest
 [PATCH 1/2] blame: add blame.showEmail configuration

which would be the polished version of the patch we have been discussing, plus tests for this particular feature, and

 [PATCH 2/2] blame: more tests

which would widen test coverage to other configuration variables and features.

Previous: Quentin NeillNext: Eric Sunshine
Message 8 of 17 in “blame: add blame.showemail config option”
  1. blame: add blame.showemail config optionQuentin Neill, Apr 24, 2015
  2. Eric SunshineApr 24, 2015
  3. Quentin NeillApr 27, 2015
  4. Junio C HamanoApr 27, 2015
  5. Eric SunshineApr 27, 2015
  6. Junio C HamanoApr 28, 2015
  7. Quentin NeillApr 30, 2015
  8. Junio C HamanoApr 30, 2015
  9. Eric SunshineApr 30, 2015
  10. Junio C HamanoApr 30, 2015
  11. Eric SunshineApr 27, 2015
  12. Junio C HamanoMay 29, 2015
  13. Quentin NeillMay 30, 2015
  14. blame: add blame.showEmail configurationQuentin Neill, May 30, 2015
  15. Junio C HamanoMay 31, 2015
  16. Quentin NeillMay 31, 2015
  17. blame: add blame.showEmail configurationQuentin Neill, May 31, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.