Re: [RFCv2 03/16] connect: rewrite feature parsing to work on string_list

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2015, 18:48 UTC
Message-ID: <xmqqk2vm2bh3.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1433203338-27493-4-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---

The change in 2/16 to extract something into a helper was sort-of guessable without any comment (i.e. perhaps it will gain new callers in later patches), but a change like this needs to hint why this is a good thing to do, I would think.

I think you'll be rerolling this anyway due to droppage of 1/16, so hopefully we'll see the next version a bit better explained than this round ;-)

Thanks.

Show 5 quoted lines

>  builtin/receive-pack.c | 13 +++++----
>  connect.c              | 79 ++++++++++++++++++++++----------------------------
>  connect.h              |  2 +-
>  upload-pack.c          | 11 +++++--
>  4 files changed, 51 insertions(+), 54 deletions(-)