Re: [RFCv2 13/16] fetch-pack: use the configured transport protocol

From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Date: Jun 2, 2015, 11:32 UTC
Message-ID: <20150602113238.GA15140@LK-Perkele-VII>
In-Reply-To: <CACsJy8AadHof8bxeD3jfZ-MKSBLXGdw23SeJLgp7sCy+N7n_GA@mail.gmail.com>

On Tue, Jun 02, 2015 at 05:02:45PM +0700, Duy Nguyen wrote:

Show 10 quoted lines

> On Tue, Jun 2, 2015 at 7:02 AM, Stefan Beller <sbeller@google.com> wrote:
> >  builtin/fetch-pack.c |  22 ++++++++++-
> >  fetch-pack.c         | 109 +++++++++++++++++++++++++++------------------------
> >  fetch-pack.h         |   1 +
> >  3 files changed, 80 insertions(+), 52 deletions(-)
> 
> And the companion changes in transport-helper.c should be in this
> patch as well to support smart http. I don't think there is any
> problem with how you store the "version" (or "transport_version", you
> should probably stick to one name) though.

Looking at transport-helper.c, process_connect() looks to need patching, it handles smart transport establishment via remote helpers.

Looking at the routine it calls, both the name and exec look to need patching.

I think that if process_connect() succeeds, then connect_setup() will hit the "if (data->conn) return 0;" case and exit early.

transport-helper.c doesn't look to have anything smart-http specific.

-Ilari