Re: [PATCH] pretty format string support for reflog times

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 27, 2016, 17:46 UTC
Message-ID: <xmqqk2g7vurb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqwpk7vw30.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 21 quoted lines

>> Hrm. Since Ted was not cc'd, it is not clear to me whether this is
>> coincidental or in response to the thread over in
>>
>>   http://thread.gmane.org/gmane.comp.version-control.git/299201
>>
>> To summarize, I think the conclusion there was that we would go with at
>> least the 't' and 'r' formatters in the short term. The 'i/I' ones were
>> not something Ted cared about that much, I think, but they do make
>> things orthogonal with the other ident dates.
>
> I forgot about that thread after it stalled without drawing
> conclusion, after Ted asked if anybody has a strong opinion
> and saw only one response to it at
>
>   https://public-inbox.org/git/20160711164317.GB3890%40thunk.org/
>
> So, what is the next step?  Apply
>
>   https://public-inbox.org/git/20160710055402.32684-1-tytso%40mit.edu/
>
> but exclude %g[iI] bits out of that patch while doing so?

FWIW, a squash to do so is trivial, but the original had two compiler breakers.

I am not sure about the latter, i.e. the return value from the get_reflog_time_t() function (which I think is misnamed, in that the function returns "unsigned long", not "time_t", and should be renamed to get_reflog_time()) uses the epoch as a fallback value.

 reflog-walk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/reflog-walk.c b/reflog-walk.c
index d0aa2d0..51bfe29 100644
--- a/reflog-walk.c
+++ b/reflog-walk.c
@@ -309,7 +309,7 @@ void get_reflog_message(struct strbuf *sb,
 	size_t len;
 
 	if (!info)
-		return NULL;
+		return;
 	len = strlen(info->message);
 	if (len > 0)
 		len--; /* strip away trailing newline */
@@ -330,7 +330,7 @@ unsigned long get_reflog_time_t(struct reflog_walk_info *reflog_info)
 	struct reflog_info *info = get_reflog_info(reflog_info);
 
 	if (!info)
-		return NULL;
+		return 0;
 	return gm_time_t(info->timestamp, info->tz);
 }