Re: [PATCH] pretty format string support for reflog times

From: Jeff King <peff@peff.net>
Date: Jul 27, 2016, 17:58 UTC
Message-ID: <20160727175800.GB32219@sigill.intra.peff.net>
In-Reply-To: <xmqqk2g7vurb.fsf@gitster.mtv.corp.google.com>

On Wed, Jul 27, 2016 at 10:46:48AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> I am not sure about the latter, i.e. the return value from the
> get_reflog_time_t() function (which I think is misnamed, in that the
> function returns "unsigned long", not "time_t", and should be
> renamed to get_reflog_time()) uses the epoch as a fallback value.
> [...]
> @@ -330,7 +330,7 @@ unsigned long get_reflog_time_t(struct reflog_walk_info *reflog_info)
>  	struct reflog_info *info = get_reflog_info(reflog_info);
>  
>  	if (!info)
> -		return NULL;
> +		return 0;
>  	return gm_time_t(info->timestamp, info->tz);
>  }

Our mails just crossed, but I think returning even "0" is not ideal. We should probably write nothing to match things like "%gd" and "%gs", which just eat the placeholder and show nothing when they cannot access the reflog.

-Peff