Re: [PATCH] send-email: Add tocmd option to suppress-cc

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2017, 17:23 UTC
Message-ID: <xmqqk24f7qep.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170613034337.GF5297@vireshk-i7>

Viresh Kumar <viresh.kumar@linaro.org> writes:

Show 18 quoted lines

>> Going back to the core part of your change, i.e.
>> 
>> -	foreach my $entry (qw (cccmd cc author self sob body bodycc)) {
>> +	foreach my $entry (qw (tocmd cccmd cc author self sob body bodycc)) {
>> 
>> to think about it a bit more, I notice that all the existing ones
>> are about CC.  So I am not just not convinced that tocmd belongs to
>> the same class.  I am inclined to say that it smells quite different
>> from others.
>
> That's right but how do we solve this problem then?
>
> Add another optional argument like suppress-to ? I thought that it
> would be better to override suppress-cc rather than attempting any
> such thing.
>
> I am fine with any solution that address the concerns raised by this
> patch though.

I am not sure what problem is being solved, quite honestly. "I have tocmd configured and I want a way not to specify tocmd for a single invocation?" Would something along the lines of

    git -c sendemail.tocmd=true send-email ...

how you do it in general? Do you want a prettier-looking equivalent, e.g.

    git send-email --tocmd=true ...

or something like that?