git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: Add tocmd option to suppress-cc

From
Viresh Kumar <viresh.kumar@linaro.org>
Date
Jun 14, 2017, 03:47 UTC
Message-ID
<20170614034754.GI5297@vireshk-i7>
In-Reply-To
<xmqqk24f7qep.fsf@gitster.mtv.corp.google.com>
On 13-06-17, 10:23, Junio C Hamano wrote:
Show 28 quoted lines
> Viresh Kumar <viresh.kumar@linaro.org> writes:
> 
> >> Going back to the core part of your change, i.e.
> >> 
> >> -	foreach my $entry (qw (cccmd cc author self sob body bodycc)) {
> >> +	foreach my $entry (qw (tocmd cccmd cc author self sob body bodycc)) {
> >> 
> >> to think about it a bit more, I notice that all the existing ones
> >> are about CC.  So I am not just not convinced that tocmd belongs to
> >> the same class.  I am inclined to say that it smells quite different
> >> from others.
> >
> > That's right but how do we solve this problem then?
> >
> > Add another optional argument like suppress-to ? I thought that it
> > would be better to override suppress-cc rather than attempting any
> > such thing.
> >
> > I am fine with any solution that address the concerns raised by this
> > patch though.
> 
> I am not sure what problem is being solved, quite honestly.  "I have
> tocmd configured and I want a way not to specify tocmd for a single
> invocation?"  Would something along the lines of 
> 
>     git -c sendemail.tocmd=true send-email ...
> 
> how you do it in general?
Yeah, it works. I can use this instead.
This patch can be dropped now. Thanks.
-- 
viresh
Previous: Junio C Hamano
Message 7 of 7 in “send-email: Add tocmd option to suppress-cc”
  1. send-email: Add tocmd option to suppress-ccViresh Kumar, May 18, 2017
  2. Viresh KumarJun 12, 2017
  3. Junio C HamanoJun 12, 2017
  4. Junio C HamanoJun 12, 2017
  5. Viresh KumarJun 13, 2017
  6. Junio C HamanoJun 13, 2017
  7. Viresh KumarJun 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.