Re: [PATCHv3 2/4] builtin/blame: dim uninteresting metadata

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 8, 2018, 19:34 UTC
Message-ID: <xmqqk1ws87qw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20180104224007.214548-3-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 6 quoted lines

> +color.blame.repeatedMeta::
> +	Use the customized color for the part of git-blame output that
> +	is repeated meta information per line (such as commit id,
> +	author name, date and timezone). Defaults to dark gray.
> +
> ...

"Dark gray on default background" may alleviate worrries from those who prefer black ink on white paper display by hinting that both foreground and background colors can be configured.

Do we want to make this overridable from the command line, i.e. --color-repeated-meta=gray?

> +#define OUTPUT_COLOR_LINE	02000

The name of the macro implies that this is (or at least can be) a lot more generic UI request than merely "paint the same metadata on adjacent lines in a different color".

> +		OPT_BIT(0, "color-lines", &output_option, N_("color redundant metadata from previous line differently"), OUTPUT_COLOR_LINE),

Should this eventually become "--color=<yes,no,auto>" that is more usual and generic, possibly defaulting to "auto" in the future, I wonder?

Show 12 quoted lines

> diff --git a/color.h b/color.h
> index 2e768a10c6..2df2f86698 100644
> --- a/color.h
> +++ b/color.h
> @@ -30,6 +30,7 @@ struct strbuf;
>  #define GIT_COLOR_BLUE		"\033[34m"
>  #define GIT_COLOR_MAGENTA	"\033[35m"
>  #define GIT_COLOR_CYAN		"\033[36m"
> +#define GIT_COLOR_DARK		"\033[1;30m"
>  #define GIT_COLOR_BOLD_RED	"\033[1;31m"
>  #define GIT_COLOR_BOLD_GREEN	"\033[1;32m"
>  #define GIT_COLOR_BOLD_YELLOW	"\033[1;33m"

How about using CYAN just like "diff" output uses it to paint the least interesting lines? That way we will keep the "uninteresting is cyan" consistency for the default settings without adding a new color to the palette.