Re: [PATCHv3 0/4] blame: (dim rep. metadata lines or fields, decay date coloring)

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Feb 1, 2018, 19:29 UTC
Message-ID: <87inbgmrug.fsf@evledraar.gmail.com>
In-Reply-To: <20180104224007.214548-1-sbeller@google.com>

On Thu, Jan 04 2018, Stefan Beller jotted:

Show 5 quoted lines

> Stefan Beller (4):
>   color.h: document and modernize header
>   builtin/blame: dim uninteresting metadata
>   builtin/blame: add option to color metadata fields separately
>   builtin/blame: highlight recently changed lines

I like this feature in principle, but I can't get it to work. Building pu and:

    ./git -c color.ui=always --exec-path=$PWD blame Makefile

Shows no colors. Neither does:

    ./git -c color.ui=always --exec-path=$PWD -c color.blame.highlightRecent="red,12 month ago,blue" blame Makefile

And there's a bug, it segfaults on any custom value to the other config option:

    ./git -c color.ui=always --exec-path=$PWD -c color.blame.repeatedMeta=red blame Makefile

    0x00000000004c312b in color_parse_mem (value=0x8f6520 "red", value_len=3, dst=0x1 <Address 0x1 out of bounds>) at color.c:272
    272                     OUT('\033');

The repeated_meta_color variable is NULL when passed to color_parse_mem(). Didn't dig further.