Re: [PATCH v6 3/3] builtin/config: introduce `color` type specifier

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2018, 01:54 UTC
Message-ID: <xmqqk1tf4yhl.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180410001834.GE67209@syl.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 12 quoted lines

> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index b644a44ae9..7c8365e377 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -177,6 +177,10 @@ Valid `<type>`'s include:
>    ~/` from the command line to let your shell do the expansion.)
>  - 'expiry-date': canonicalize by converting from a fixed or relative date-string
>    to a timestamp. This specifier has no effect when setting the value.
> +- 'color': When getting a value, canonicalize by converting to an ANSI color
> +  escape sequence. When setting a value, a sanity-check is performed to ensure
> +  that the given value is canonicalize-able as an ANSI color, but it is written
> +  as-is.

This makes sense, in the same spirit as a value with "path" type where tilde expansion is not done at all while setting.

Will queue.  Thanks.