Re: [PATCH v4 1/3] builtin/config: introduce `--default`
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Apr 6, 2018, 05:50 UTC
- Message-ID
- <20180406055037.GB62593@syl.local>
- In-Reply-To
- <CAPig+cQwj8tqJToKU0_emHHC+mdtpPS666XJ7sqentMAFoLivw@mail.gmail.com>
On Thu, Apr 05, 2018 at 06:40:03PM -0400, Eric Sunshine wrote:
Show 16 quoted lines
> On Wed, Apr 4, 2018 at 10:59 PM, Taylor Blau <me@ttaylorr.com> wrote: > > [...] > > This commit (and those following it in this series) aim to eventually > > replace `--get-color` with a consistent alternative. By introducing > > `--default`, we allow the `--get-color` action to be promoted to a > > `--type=color` type specifier, retaining the "fallback" behavior via the > > `--default` flag introduced in this commit. > > [...] > > > > Signed-off-by: Taylor Blau <me@ttaylorr.com> > > --- > > diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt > > @@ -235,6 +235,10 @@ Valid `<type>`'s include: > > +--default value:: > > This should be typeset as: --default <value>
I see; thank you for letting me know. I have updated this in the forthcoming re-roll.
Show 6 quoted lines
> > + When using `--get`, and the requested slot is not found, behave as if value > > + were the value assigned to the that slot. > > And you might use "behaves as if <value>" in the body as well (though > I think Git documentation isn't terribly consistent about typesetting > as "<value>" in the body, so I don't insist upon it).
Since I'm here, and re-rolling anyway, I have included this change as well.
Thanks, Taylor