Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

From: Junio C Hamano <gitster@pobox.com>
Date: May 23, 2018, 02:05 UTC
Message-ID: <xmqqk1rvw2i1.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAE5ih79_Ai8F48zFpJ09e8saGrySoiyVdsgkk8ZpRrQAd15a4g@mail.gmail.com>

Luke Diamand <luke@diamand.org> writes:

Show 8 quoted lines

>> However, instead of a separate patch, wouldn't it be better to squash
>> it into the previous one?  So 'make test' would succeed on every
>> commit even with a newer p4 version.
>
> Junio?
>
> I can squash together the original commit and the two fixes if that
> would be better?

Among the three hunks in this fix-up patch, the first two are strictly fixing what you had in the previous patch, so it make sense to fix them at the source by squashing.

The last one (i.e. "even if it is verbose, if fileSize is not reported, do not write the verbose output") does not look like it is limited to the unshelve feature, so it might, even though it is a one-liner, deserve to be a separate preparatory patch if you want. But I do not feel strongly about either way.

Thanks.