git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] git-p4: unshelve: use action==add instead of rev==none

From
MAMazo, Andrey <amazo@checkvideo.com>
Date
May 23, 2018, 16:41 UTC
Message-ID
<BYAPR08MB38451D101964D3B4D10436EBDA6B0@BYAPR08MB3845.namprd08.prod.outlook.com>
In-Reply-To
<xmqqk1rvw2i1.fsf@gitster-ct.c.googlers.com>
Show 5 quoted lines
> The last one (i.e. "even if it is verbose, if fileSize is not
> reported, do not write the verbose output") does not look like it is
> limited to the unshelve feature, so it might, even though it is a
> one-liner, deserve to be a separate preparatory patch if you want.
> But I do not feel strongly about either way.

This was actually discussed in a separate thread [1] some time ago with patches proposed by Thandesha and me. I haven't yet got time to cook a final patch, which addresses both Thandesha's and mine use-cases though, so this wasn't submitted to Junio yet. In the meantime, I guess, one of the patches [2] from that thread can be taken as is.

[1] "[BUG] git p4 clone fails when p4 sizes does not return 'fileSize' key"
      https://public-inbox.org/git/CAJJpmi-pLb4Qcka5aLKXA8B1VOZFFF+OAQ0fgUq9YviobRpYGg@mail.gmail.com/t/#mee2ec50a40242089741f808f06214a44278055b3
[2] "[PATCH 1/1] git-p4: fix `sync --verbose` traceback due to 'fileSize'"
      https://public-inbox.org/git/2e2b2add4e4fffa4228b8ab9f6cd47fa9bf25207.1523981210.git.amazo@checkvideo.com/

Thank you, Andrey Mazo

Previous: Luke DiamandNext: Luke Diamand
Message 8 of 10 in “git-p4: unshelving: fix problem with newer P4”
  1. 0/1 git-p4: unshelving: fix problem with newer P4Luke Diamand, May 22, 2018
  2. 1/1 git-p4: unshelve: use action==add instead of rev==noneLuke Diamand, May 22, 2018
  3. SZEDER GáborMay 22, 2018
  4. Luke DiamandMay 22, 2018
  5. Junio C HamanoMay 23, 2018
  6. 0/1 git-p4: unshelve: fix problem with newer p4dLuke Diamand, May 23, 2018
  7. 1/1 git-p4: add unshelve commandLuke Diamand, May 23, 2018
  8. Mazo, AndreyMay 23, 2018
  9. Luke DiamandMay 23, 2018
  10. Mazo, AndreyMay 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.