Re: [PATCH 1/3] t6501: use --quiet when testing gc stderr

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 19, 2018, 00:36 UTC
Message-ID: <xmqqk1me4vrw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <90d051a5-8c02-518d-01a7-16746061e6b9@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 7 quoted lines

> This code from builtin/gc.c makes it look like we are doing that:
>
>         if (gc_write_commit_graph)
>                 write_commit_graph_reachable(get_object_directory(), 0,
>                                              !quiet && !daemonized);
>
> But really, daemonized is only for when running in the background.

But that is something we can easily fix, no?

"git grep isatty" tells you that we use isatty(2) to decide if we want to go verbose or show progress. Another frequent use of isatty in our codebase of course is to use of a pager and columnar output formats.