git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] t6501: use --quiet when testing gc stderr

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 18, 2018, 05:23 UTC
Message-ID
<xmqq1s8nvndm.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<ab118e60e9988076edf43d0ed8c1924e6569a9d0.1539808389.git.gitgitgadget@gmail.com>
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 7 quoted lines
> From: Derrick Stolee <dstolee@microsoft.com>
>
> The test script t6501-freshen-objects.sh has some tests that care
> if 'git gc' has any output to stderr. This is intended to say that
> no warnings occurred related to broken links. However, when we
> have operations that output progress (like writing the commit-graph)
> this causes the test to fail.

I see that the descriptor #2 is redirected into a regular file. Why should we be writing the progress indicator in that case in the first place? Shoudln't we be doing the usual "are we showing this to an interactive terminal?" test?

Previous: Derrick Stolee via GitGitGadgetNext: Derrick Stolee
Message 3 of 9 in “Use commit-graph by default”
  1. 0/3 Use commit-graph by defaultDerrick Stolee via GitGitGadget, Oct 17, 2018
  2. 1/3 t6501: use --quiet when testing gc stderrDerrick Stolee via GitGitGadget, Oct 17, 2018
  3. Junio C HamanoOct 18, 2018
  4. Derrick StoleeOct 18, 2018
  5. Junio C HamanoOct 19, 2018
  6. 2/3 t: explicitly turn off core.commitGraph as neededDerrick Stolee via GitGitGadget, Oct 17, 2018
  7. 3/3 commit-graph: Use commit-graph by defaultDerrick Stolee via GitGitGadget, Oct 17, 2018
  8. Junio C HamanoOct 18, 2018
  9. Derrick StoleeOct 18, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.