git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy] [PATCH] blame: Convert pickaxe_blame defined constants to enums

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 12, 2019, 00:30 UTC
Message-ID
<xmqqk19ag60g.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20191011184441.103527-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 9 quoted lines
>> > Also, I have a slight preference for putting "= 02" on the BLAME_COPY
>> > line but that is not necessary.
>> 
>> That is absolutely necessary; it is not like "we do not care what
>> exact value _COPY gets; it can be any value as long as it is _MOVE
>> plus 1", as these are used in set of bits (and again, I do not think
>> it is such a brilliant idea to use enum for such a purpose).
>
> Good point.

Doesn't that also show that enums are not quite a good fit for set of bits (i.e. 1<<n)?

Previous: Jonathan TanNext: Jonathan Tan
Message 5 of 13 in “blame: Convert pickaxe_blame defined constants to enums”
  1. Wambui KarugaOct 10, 2019
  2. Jonathan TanOct 10, 2019
  3. Junio C HamanoOct 11, 2019
  4. Jonathan TanOct 11, 2019
  5. Junio C HamanoOct 12, 2019
  6. Jonathan TanOct 14, 2019
  7. Wambui KarugaOct 14, 2019
  8. Jonathan TanOct 14, 2019
  9. Wambui KarugaOct 15, 2019
  10. SZEDER GáborOct 15, 2019
  11. Wambui KarugaOct 11, 2019
  12. Jonathan TanOct 11, 2019
  13. Wambui KarugaOct 11, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.