From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 12 Oct 2019 00:30:07 GMT
Subject: Re: [Outreachy] [PATCH] blame: Convert pickaxe_blame defined constants to enums
Message-ID: <xmqqk19ag60g.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191011184441.103527-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>> > Also, I have a slight preference for putting "= 02" on the BLAME_COPY
>> > line but that is not necessary.
>> 
>> That is absolutely necessary; it is not like "we do not care what
>> exact value _COPY gets; it can be any value as long as it is _MOVE
>> plus 1", as these are used in set of bits (and again, I do not think
>> it is such a brilliant idea to use enum for such a purpose).
>
> Good point.

Doesn't that also show that enums are not quite a good fit for set
of bits (i.e. 1<<n)?