git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make some commit hashes in tests reproducible

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2020, 22:37 UTC
Message-ID
<xmqqk0zf2bpl.fsf@gitster.c.googlers.com>
In-Reply-To
<20200707215206.GA2300296@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> I'm also skeptical how often we use system times anyway, because _any_
> use of test_commit or test_tick in a script is enough to make all of the
> subsequent commands deterministic. I'd be more inclined to let a
> particular script say "I'm interested in random times". But then, I'd
> think such a script would be better written to trigger its interesting
> cases with a well-crafted set of deterministic times.
Yeah, the DEVELOPER=YesPlease was a tongue-in-cheek comment.

Reproducibility would mean we see less test breakages due to raciness, but I do not recall a case where digging into test breakage due to raciness led to discovery of and fix to a real breakage in Git itself, so it is probably a good thing.

Thanks.
Previous: Jeff KingNext: Jeff King
Message 6 of 8 in “Make some commit hashes in tests reproducible”
  1. Make some commit hashes in tests reproducibleHan-Wen Nienhuys via GitGitGadget, Jul 7, 2020
  2. Junio C HamanoJul 7, 2020
  3. Jeff KingJul 7, 2020
  4. Junio C HamanoJul 7, 2020
  5. Jeff KingJul 7, 2020
  6. Junio C HamanoJul 7, 2020
  7. Jeff KingJul 7, 2020
  8. Han-Wen NienhuysJul 8, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.